digest v0.11.0-rc.0#1868
Merged
Merged
Conversation
NOTE: this temporarily disables the `ecdh`, `hash2curve`, and `oprf` features of `elliptic-curve` to make the release possible. Going forward we can remove the `=` from the `digest` version requirement now that we're done making major breaking changes, which should allow for more flexible upgrades. They can be re-enabled when the `hmac`, `hkdf`, `sha2`, and `sha3` crates have been updated.
tarcieri
commented
May 28, 2025
Comment on lines
-19
to
-21
| [dev-dependencies] | ||
| hex-literal = "1" | ||
| sha2 = { version = "=0.11.0-pre.5", default-features = false } |
Member
Author
There was a problem hiding this comment.
Turns out these were no-longer used
newpavlov
approved these changes
May 29, 2025
Member
|
Note that I have one additional minor breaking change in mind: I want to make serialization of eager hashes slightly more efficient. |
tarcieri
added a commit
that referenced
this pull request
May 29, 2025
Due to inter-repo dependency relationships and all of the crates previously using `=` to pin `digest`, some of the features of `elliptic-curve` had to be disabled to complete the `digest` v0.11.0-rc.0 release in #1868. Now that it's been released and there are new compatible versions of the `hkdf`, `sha2`, and `sha3` crates, it's possible to re-enable this functionality.
tarcieri
added a commit
that referenced
this pull request
May 29, 2025
Due to inter-repo dependency relationships and all of the crates previously using `=` to pin `digest`, some of the features of `elliptic-curve` had to be disabled to complete the `digest` v0.11.0-rc.0 release in #1868. Now that it's been released and there are new compatible versions of the `hkdf`, `sha2`, and `sha3` crates, it's possible to re-enable this functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this temporarily disables the
ecdh,hash2curve, andoprffeatures ofelliptic-curveto make the release possible.They can be re-enabled when the
hmac,hkdf,sha2, andsha3crates have been updated.Going forward we can remove the
=from thedigestversion requirement now that we're done making major breaking changes, which should allow for more flexible upgrades.